fix(NKFile+Extensions): prevent __NC_ROOT__ from appearing#128
Merged
Conversation
With nextcloud/NextcloudKit#169 the sync root folder name has changed. This required consumers of the API to update the handling of the root folder case accordingly. BUG: nextcloud/desktop#8832 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of Nextcloud's root folder representation by updating code to use the new __NC_ROOT__ filename convention instead of the previous "." convention, following changes in NextcloudKit #169.
- Updates root folder detection logic to use NextcloudKit's new root filename constant
- Replaces hardcoded root folder identifiers with proper server URL construction
- Updates test cases to reflect the new root folder naming convention
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/NextcloudFileProviderKit/Extensions/NKFile+Extensions.swift | Updates root folder detection logic to use NextcloudKit's rootFileName constant and proper server URL construction |
| Sources/NextcloudFileProviderKit/Enumeration/Enumerator+SyncEngine.swift | Updates file filtering condition to use new root folder identification method |
| Tests/NextcloudFileProviderKitTests/NKFileExtensionTests.swift | Updates test cases to use new root folder filename and server URL format |
| Tests/InterfaceTests/MockRemoteInterfaceTests.swift | Updates test assertions to expect new root folder naming convention |
| Tests/Interface/MockRemoteItem.swift | Updates mock implementation to generate NKFile objects with new root folder format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Aiiaiiio
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With nextcloud/NextcloudKit#169 the sync root folder name has changed. This required consumers of the API to update the handling of the root folder case accordingly.
I am not 100% sure if the fix is correct, but at least the folder no longer shows up on a local build, and the tests are happy after updating them again to replicate NextcloudKit's behaviour as well.
Part of nextcloud/desktop#8832